Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dst: Log a warning when the controller clients receive an error #2499

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Nov 1, 2023

The controller client includes a recovery/backoff module that causes resolutions to be retried when an unexpected error is encountered. These events are only logged at debugging and trace log levels.

This change updates the destination controller recovery module to log unexpected errors. This will benefit both profile and endpoint resolution.

The controller client includes a recovery/backoff module that causes
resolutions to be retried when an unexpected error is encountered.
These events are only logged at debugging and trace log levels.

This change updates the destination controller recovery module to log
unexpected errors. This will benefit both profile and endpoint
resolution.
@olix0r olix0r requested a review from a team as a code owner November 1, 2023 18:54
@olix0r
Copy link
Member Author

olix0r commented Nov 1, 2023

Followup for linkerd/linkerd2#11555

@olix0r olix0r merged commit 920b2dd into main Nov 1, 2023
11 of 12 checks passed
@olix0r olix0r deleted the ver/log-disco-error branch November 1, 2023 23:18
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would
not properly reflect grpc-status in metrics by default.

Furthermore, proxies now long warnings when they receive unexpected
error responses from the control plane.

---

* chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487)
* gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491)
* Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498)
* gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493)
* Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499)
* inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496)

Signed-off-by: Oliver Gould <[email protected]>
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would
not properly reflect grpc-status in metrics by default.

Furthermore, proxies now long warnings when they receive unexpected
error responses from the control plane.

---

* chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487)
* gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491)
* Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498)
* gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493)
* Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499)
* inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496)

Signed-off-by: Oliver Gould <[email protected]>
alpeb pushed a commit that referenced this pull request Nov 6, 2023
The controller client includes a recovery/backoff module that causes
resolutions to be retried when an unexpected error is encountered.
These events are only logged at debugging and trace log levels.

This change updates the destination and policy controller recovery
modules to log unexpected errors as warnings.
alpeb added a commit to linkerd/linkerd2 that referenced this pull request Nov 6, 2023
## stable-2.14.3

This stable release fixes an issue in the Destination controller that was
forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases
the log level from debug to warning when the outbound proxy faces this type of
events.

* Fixed `GetProfiles` error when address is opaque and unmeshed ([#11556],
  fixes[#11555])
* Started logging at warning level when the controller clients receive an error
  ([#2499])

[#11556]: #11556
[#11555]: #11555
[#2499]: linkerd/linkerd2-proxy#2499
hawkw pushed a commit that referenced this pull request Nov 6, 2023
The controller client includes a recovery/backoff module that causes
resolutions to be retried when an unexpected error is encountered.
These events are only logged at debugging and trace log levels.

This change updates the destination and policy controller recovery
modules to log unexpected errors as warnings.
alpeb added a commit to linkerd/linkerd2 that referenced this pull request Nov 7, 2023
Changes for stable-2.14.3

This stable release fixes an issue in the Destination controller that was
forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases
the log level from debug to warning when the outbound proxy faces this type of
events.

* Fixed `GetProfiles` error in the Destination controller when address is opaque
  and unmeshed ([#11556], fixes[#11555])
* Started logging at warning level in the proxy when the controller clients
  receive an error ([#2499])

[#11556]: #11556
[#11555]: #11555
[#2499]: linkerd/linkerd2-proxy#2499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants