Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace-level Configs Override Annotations #2499

Closed
ihcsim opened this issue Mar 14, 2019 · 1 comment · Fixed by #3194
Closed

Namespace-level Configs Override Annotations #2499

ihcsim opened this issue Mar 14, 2019 · 1 comment · Fixed by #3194
Assignees
Labels

Comments

@ihcsim
Copy link
Contributor

ihcsim commented Mar 14, 2019

Feature Request

What problem are you trying to solve?

Extend the configs override annotations to work at the namespace level. This will allow proxy configs to be overridden for all workloads in a namespace, so that the users won't have to repeat the annotations on each workload.

Following our discussion in #2497, we've decided to exclude this feature from that PR, until we see a realistic use for it.

How should the problem be solved?

Update the conf.getOverride() method to look up any namespace annotations, if no pod-level annotations are present.

How would users interact with this feature?

Specifying the config annotations in the namespace's metadata.

@stale
Copy link

stale bot commented Jun 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants