Fix GetProfiles error when address is opaque and unmeshed #11556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Nov 2, 2023
mateiidavid
approved these changes
Nov 2, 2023
olix0r
added a commit
that referenced
this pull request
Nov 2, 2023
This edge release fixes two bugs in the Destination controller that could cause outbound connections to hang indefinitely. * helm: Introduce configurable values for protocol detection ([#11536]) * destination: Fix GetProfiles error when address is opaque and unmeshed ([#11556]) * destination: Return NotFound for unknown pod names ([#11540]) * proxy: Log controller errors at WARN * proxy: Fix grpc_status metric labels for inbound traffic [#11536]: #11536 [#11556]: #11556 [#11540]: #11540
Merged
olix0r
added a commit
that referenced
this pull request
Nov 2, 2023
This edge release fixes two bugs in the Destination controller that could cause outbound connections to hang indefinitely. * helm: Introduce configurable values for protocol detection ([#11536]) * destination: Fix GetProfiles error when address is opaque and unmeshed ([#11556]) * destination: Return NotFound for unknown pod names ([#11540]) * proxy: Log controller errors at WARN * proxy: Fix grpc_status metric labels for inbound traffic [#11536]: #11536 [#11556]: #11556 [#11540]: #11540
alpeb
pushed a commit
that referenced
this pull request
Nov 6, 2023
When we do a GetProfile lookup for an opaque port on an unmeshed pod, we attempt to look up the inbound listen port of that pod's proxy. Since that pod has no proxy, this fails and we return an error to the GetProfile API call. This causes the proxy to fail to be able to resolve the profile and be unable to route the traffic. We revert to the previous behavior of only logging when we cannot look up the inbound listen port instead of returning an error. Signed-off-by: Alex Leong <[email protected]>
alpeb
added a commit
that referenced
this pull request
Nov 6, 2023
## stable-2.14.3 This stable release fixes an issue in the Destination controller that was forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases the log level from debug to warning when the outbound proxy faces this type of events. * Fixed `GetProfiles` error when address is opaque and unmeshed ([#11556], fixes[#11555]) * Started logging at warning level when the controller clients receive an error ([#2499]) [#11556]: #11556 [#11555]: #11555 [#2499]: linkerd/linkerd2-proxy#2499
alpeb
added a commit
that referenced
this pull request
Nov 7, 2023
Changes for stable-2.14.3 This stable release fixes an issue in the Destination controller that was forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases the log level from debug to warning when the outbound proxy faces this type of events. * Fixed `GetProfiles` error in the Destination controller when address is opaque and unmeshed ([#11556], fixes[#11555]) * Started logging at warning level in the proxy when the controller clients receive an error ([#2499]) [#11556]: #11556 [#11555]: #11555 [#2499]: linkerd/linkerd2-proxy#2499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do a
GetProfilelookup for an opaque port on an unmeshed pod, we attempt to look up the inbound listen port of that pod's proxy. Since that pod has no proxy, this fails and we return an error to theGetProfileAPI call. This causes the proxy to fail to be able to resolve the profile and be unable to route the traffic.We revert to the previous behavior of only logging when we cannot look up the inbound listen port instead of returning an error.