chore: change rust-toolchain file to toml format
#2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rust-toolchain` file containing only a Rust version number is deprecated in favor of a TOML-formatted `rust-toolchain.toml`. Using the old format seems to make Dependabot unhappy --- it complains that: ``` only rust-toolchain files formatted as TOML are supported, the non-TOML format was deprecated by Rust ``` Therefore, this branch changes the toolchain file in this repo to the TOML format.
hawkw
added a commit
that referenced
this pull request
Oct 19, 2023
This commit updates the proxy's dependency on `rustix` in order to resolve a potential memory exhaustion issue when using the `rustix::fs::Dir` iterator with the `linux-raw` backend. This issue is described in GHSA-c827-hfw6-qwvm. We currently depend on both `rustix` v0.36 and v0.37 as transitive deps, so this branch updates the v0.36 dep from v0.36.14 to v0.36.16, and the v0.37 dependency from v0.37.4 to v0.37.7. Unfortunately, we weren't able to get Dependabot to bump these deps for us, because it no longer supports the legacy (non-TOML) `rust-toolchain` file (see #2487 for details). Therefore, we have to do this bump manually.
olix0r
pushed a commit
that referenced
this pull request
Oct 19, 2023
This commit updates the proxy's dependency on `rustix` in order to resolve a potential memory exhaustion issue when using the `rustix::fs::Dir` iterator with the `linux-raw` backend. This issue is described in GHSA-c827-hfw6-qwvm. We currently depend on both `rustix` v0.36 and v0.37 as transitive deps, so this branch updates the v0.36 dep from v0.36.14 to v0.36.16, and the v0.37 dependency from v0.37.4 to v0.37.7. Unfortunately, we weren't able to get Dependabot to bump these deps for us, because it no longer supports the legacy (non-TOML) `rust-toolchain` file (see #2487 for details). Therefore, we have to do this bump manually.
|
okay this works now |
olix0r
approved these changes
Oct 23, 2023
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would not properly reflect grpc-status in metrics by default. Furthermore, proxies now long warnings when they receive unexpected error responses from the control plane. --- * chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487) * gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491) * Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498) * gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493) * Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499) * inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496) Signed-off-by: Oliver Gould <[email protected]>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would not properly reflect grpc-status in metrics by default. Furthermore, proxies now long warnings when they receive unexpected error responses from the control plane. --- * chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487) * gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491) * Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498) * gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493) * Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499) * inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496) Signed-off-by: Oliver Gould <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rust-toolchainfile containing only a Rust version number is deprecated in favor of a TOML-formattedrust-toolchain.toml. Using the old format seems to make Dependabot unhappy --- it complains that:Therefore, this branch changes the toolchain file in this repo to the TOML format.