Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old unused scripts from misc/ #13286

Merged
merged 5 commits into from
Aug 23, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 29, 2022

I've gone through all scripts in misc/ and scripts/.
Here's what I found:

  1. There was only one script in scripts/, so I moved it to misc/, not sure if it is still needed though: we now have existing IDE integrations, including emacs
  2. I removed old files created back in 2016, that were never touched afterwards (except with autoformatters)

Please, correct me if I am removing something useful. Maybe there are other outdated / unused scripts that I've missed?

Refs #2117

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@ethanhs ethanhs requested review from JukkaL and removed request for JukkaL August 5, 2022 05:52
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these is a good idea (except maybe for one file -- see my comment).

There are conflicts, apparently from the switch to the new syntax for built-in generics.

@@ -1,199 +0,0 @@
#!/usr/bin/env python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is the only one that might possibly be useful in the future.

@AlexWaygood AlexWaygood mentioned this pull request Aug 23, 2022
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn sobolevn merged commit 1efb110 into python:master Aug 23, 2022
@sobolevn
Copy link
Member Author

Thank you, @JukkaL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants