Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run a type check on scripts and most of misc in CI #13458

Merged
merged 1 commit into from
Aug 20, 2022
Merged

Run a type check on scripts and most of misc in CI #13458

merged 1 commit into from
Aug 20, 2022

Conversation

AlexWaygood
Copy link
Member

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member

I think it is worth mentioning that many files there appear to be unused: #13286

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Aug 20, 2022 •
edited
Loading

I think it is worth mentioning that many files there appear to be unused: #13286

Yeah. I can't comment on whether or not these files are actually used/needed, but if that PR is merged, it would obviously make some of the changes here redundant :)

@hauntsaninja hauntsaninja merged commit 5f488e2 into python:master Aug 20, 2022
@AlexWaygood AlexWaygood deleted the misc-typecheck branch August 20, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @sobolevn @hauntsaninja