Use new tuples #13487
Merged
Use new tuples #13487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to special-case |
AlexWaygood
reviewed
Aug 23, 2022
tox.ini
Outdated
| @@ -56,7 +56,6 @@ commands = | |||
| description = type check ourselves | |||
| commands = | |||
| python -m mypy --config-file mypy_self_check.ini -p mypy -p mypyc | |||
| python -m mypy --config-file mypy_self_check.ini scripts | |||
There was a problem hiding this comment.
Did you mean to do this as part of this PR? Looks like it maybe should have been done as part of #13286? :)
This reverts commit 552b7d2.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Aug 23, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just noticed it in a couple of places :)