Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

Merged
merged 9 commits into from
Jun 19, 2020
Merged

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a45739f
bpo-40077: Convert _bz2 module to use PyType_FromSpec
corona10 Jun 18, 2020
fcc9726
bpo-40077: Re-enable pickle test
corona10 Jun 18, 2020
e1e4c4a
bpo-40077: nit fix
corona10 Jun 18, 2020
54d233c
bpo-40077: Apply code review
corona10 Jun 18, 2020
498b453
bpo-40077: fix
corona10 Jun 18, 2020
09944c9
bpo-40077: Apply Victor's review
corona10 Jun 19, 2020
58073f6
bpo-40077: Add Py_tp_traverse
corona10 Jun 19, 2020
043590b
bpo-40077: fix
corona10 Jun 19, 2020
89ecd25
bpo-40077: Apply Victor's review
corona10 Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-40077: Convert _bz2 module to use PyType_FromSpec
  • Loading branch information
@corona10
corona10 committed Jun 18, 2020
commit a45739f8b30c151be4409a72d02c9ef7d7788f06
6 changes: 4 additions & 2 deletions Lib/test/test_bz2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,8 @@ def testCompress4G(self, size):
data = None

def testPickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
# Why?
for proto in range(2, pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises(TypeError):
pickle.dumps(BZ2Compressor(), proto)

Expand Down Expand Up @@ -724,7 +725,8 @@ def testDecompress4G(self, size):
decompressed = None

def testPickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
# Why?
for proto in range(2, pickle.HIGHEST_PROTOCOL + 1):
corona10 marked this conversation as resolved.
Show resolved Hide resolved
with self.assertRaises(TypeError):
pickle.dumps(BZ2Decompressor(), proto)

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-06-18-19-04-30.bpo-40077._yI-ax.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Convert :mod:`_bz2` to use :c:func:`PyType_FromSpec`.
Loading