Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

Merged
merged 9 commits into from
Jun 19, 2020
Merged

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

merged 9 commits into from
Jun 19, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jun 18, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner June 18, 2020 10:05
corona10
corona10 commented Jun 18, 2020
View reviewed changes
Lib/test/test_bz2.py Outdated Show resolved Hide resolved
@corona10 corona10 marked this pull request as draft June 18, 2020 13:15
@vstinner
Copy link
Member

I don't think that it should be possible to serialize a Compressor or Decompressor object. There is no getstate/setstate or reduce methods which would serialize attributes only accessible in C. More generally, I don't think that it would be useful, nor needed.

See https://bugs.python.org/issue40077#msg371813

vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Modules/_bz2module.c Outdated Show resolved Hide resolved
@corona10 corona10 marked this pull request as ready for review June 18, 2020 17:04
@corona10
Copy link
Member Author

@vstinner Thanks updated!

@corona10 corona10 requested a review from vstinner June 18, 2020 17:06
vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Modules/_bz2module.c Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from vstinner June 19, 2020 14:21
vstinner
vstinner reviewed Jun 19, 2020
View reviewed changes
Modules/_bz2module.c Outdated Show resolved Hide resolved
Modules/_bz2module.c Outdated Show resolved Hide resolved
@corona10 corona10 requested a review from vstinner June 19, 2020 14:54
vstinner
vstinner approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 closed this Jun 19, 2020
@corona10 corona10 reopened this Jun 19, 2020
@corona10 corona10 merged commit ec68918 into python:master Jun 19, 2020
@corona10 corona10 deleted the bpo-40077-bz2 branch June 19, 2020 15:56
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@corona10 @fasihahmad
bpo-40077: Convert _bz2 module to use PyType_FromSpec (pythonGH-20960)
4a9bcd5
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@corona10 @arun-mani-j
bpo-40077: Convert _bz2 module to use PyType_FromSpec (pythonGH-20960)
2e9a26b
@corona10 corona10 mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot