Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

Merged
merged 9 commits into from
Jun 19, 2020
Merged

bpo-40077: Convert _bz2 module to use PyType_FromSpec #20960

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a45739f
bpo-40077: Convert _bz2 module to use PyType_FromSpec
corona10 Jun 18, 2020
fcc9726
bpo-40077: Re-enable pickle test
corona10 Jun 18, 2020
e1e4c4a
bpo-40077: nit fix
corona10 Jun 18, 2020
54d233c
bpo-40077: Apply code review
corona10 Jun 18, 2020
498b453
bpo-40077: fix
corona10 Jun 18, 2020
09944c9
bpo-40077: Apply Victor's review
corona10 Jun 19, 2020
58073f6
bpo-40077: Add Py_tp_traverse
corona10 Jun 19, 2020
043590b
bpo-40077: fix
corona10 Jun 19, 2020
89ecd25
bpo-40077: Apply Victor's review
corona10 Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-40077: Apply Victor's review
  • Loading branch information
@corona10
corona10 committed Jun 19, 2020
commit 89ecd25b3b88a78f01bea72bc573621d6f7bd322
11 changes: 7 additions & 4 deletions Modules/_bz2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ BZ2_Free(void* ctx, void *ptr)
PyMem_RawFree(ptr);
}

// TODO: Convert it to clinic

/* Argument Clinic is not used since the Argument Clinic always want to
check the type which would be wrong here */
static int
_bz2_BZ2Compressor___init___impl(BZ2Compressor *self, int compresslevel)
{
Expand Down Expand Up @@ -415,7 +417,7 @@ static PyType_Spec bz2_compressor_type_spec = {
.name = "_bz2.BZ2Compressor",
.basicsize = sizeof(BZ2Compressor),
// Calling PyType_GetModuleState() on a subclass is not safe.
// dbmtype_spec does not have Py_TPFLAGS_BASETYPE flag
// bz2_compressor_type_spec does not have Py_TPFLAGS_BASETYPE flag
// which prevents to create a subclass.
// So calling PyType_GetModuleState() in this file is always safe.
.flags = Py_TPFLAGS_DEFAULT,
Expand Down Expand Up @@ -655,7 +657,8 @@ _bz2_BZ2Decompressor___reduce___impl(BZ2Decompressor *self)
return NULL;
}

// TODO: Convert it to clinic
/* Argument Clinic is not used since the Argument Clinic always want to
check the type which would be wrong here */
static int
_bz2_BZ2Decompressor___init___impl(BZ2Decompressor *self)
{
Expand Down Expand Up @@ -781,7 +784,7 @@ static PyType_Spec bz2_decompressor_type_spec = {
.name = "_bz2.BZ2Decompressor",
.basicsize = sizeof(BZ2Decompressor),
// Calling PyType_GetModuleState() on a subclass is not safe.
// dbmtype_spec does not have Py_TPFLAGS_BASETYPE flag
// bz2_decompressor_type_spec does not have Py_TPFLAGS_BASETYPE flag
// which prevents to create a subclass.
// So calling PyType_GetModuleState() in this file is always safe.
.flags = Py_TPFLAGS_DEFAULT,
Expand Down