WinAppSDK upgrade time! (after .84 is verified stable) #34622
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
arm64 passed, x64 errored for some reason |
|
I've fixed MeasureToolUI to remove the title bar and borders that WASDK 1.6 seems to have added: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/modules/MeasureTool/MeasureToolUI/MeasureToolXAML/MainWindow.xaml.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
| @@ -56,6 +56,11 @@ public MainWindow(PowerToys.MeasureToolCore.Core core) | |||
| this.SetIsMaximizable(false); | |||
| IsTitleBarVisible = false; | |||
|
|
|||
| // Remove the caption style from the window style. Windows App SDK 1.6 upgraded added it, which made the title bar and borders appear for Measure Tool. This code removes it. | |||
There was a problem hiding this comment.
This could be due to a change w/ 1.6 and the fact we use WinUIEx for that
src/modules/MeasureTool/MeasureToolUI/MeasureToolXAML/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
src/modules/previewpane/UnitTests-SvgPreviewHandler/UnitTests-SvgPreviewHandler.csproj
Outdated
Show resolved
Hide resolved
…ow.xaml.cs Co-authored-by: Dustin L. Howett <[email protected]>
…oft/powertoys into dev/crutkas/testWinApp1.6
There was a problem hiding this comment.
I have done a quick sanity check across utilities/windows on W10.
It looks like the Settings Flyout requires the the same work-around applied to Screen Ruler.
#24907 needs also to be reverted since the tracked issue has been fixed in WASDK1.6
EDIT: happy to commit the required changes. Just let me know if the Flyout has the same issue on W11.
|
@davidegiacometti please submit fix! |
|
alternative, could this be "good enough" and get it in and do a PR to fix this |
Summary of the Pull Request
This upgrades to WinAppSDK 1.6, updates WebView2 and CsWinRT
Learnings from: #34437
We will also need Community Toolkit upgraded as well via #34419
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed