Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] WinAppSDK 1.6 Flyout Fix #34821

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested the flyout with light/dark theme.

0.84.1 (left) - PR (right)
image
Untitled

@crutkas crutkas added Needs-Review This Pull Request awaits the review of a maintainer. labels Sep 12, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 7640258 into main Sep 12, 2024
14 checks passed
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/flyout-fix-main branch September 12, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants