Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinAppSDK upgrade time! (after .84 is verified stable) #34622

Merged
merged 8 commits into from
Sep 11, 2024
Prev Previous commit
Next Next commit
Fix spellchecker
  • Loading branch information
jaimecbernardo committed Sep 6, 2024
commit 25554337bcc0329ee340d3a878935daa8375b3ed
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public MainWindow(PowerToys.MeasureToolCore.Core core)
this.SetIsMaximizable(false);
IsTitleBarVisible = false;

// Remove the caption stle from the window style. Windows App SDK 1.6 upgraded added it, which made the title bar and borders appear for Measure Tool. This code removes it.
// Remove the caption style from the window style. Windows App SDK 1.6 upgraded added it, which made the title bar and borders appear for Measure Tool. This code removes it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a bug on their side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be due to a change w/ 1.6 and the fact we use WinUIEx for that

crutkas marked this conversation as resolved.
Show resolved Hide resolved
var windowStyle = GetWindowLong(hwnd, GWL_STYLE);
windowStyle = windowStyle & (~WS_CAPTION);
_ = SetWindowLong(hwnd, GWL_STYLE, windowStyle);
Expand Down
Loading