HDFS-10930.07.patch #160
Closed
HDFS-10930.07.patch #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp7
reviewed
Nov 14, 2016
There was a problem hiding this comment.
Thanks @xiaoyuyao. The patch looks good overall. Findbugs flagged a few warnings and the TestWriteToReplica failure looks related.
There's a few remaining static methods like Storage#rename, and DatanodeUtil#createTmpFile that aren't as easy to factor out. We can look at them in a subsequent Jira.
In a subsequent change we'll want to move the refactored methods into interfaces for testability and optional instrumentation.
xiaoyuyao
force-pushed
the
HDFS-10930
branch
from
ae8b273
to
1cd7ae8
Compare
|
Update PR to fix the findbugs and unit test failure. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
We will compute triggering duration as follows: - If user configures `task.window.ms` we will honor it as the triggering duration - If not, we will use the `GCD(windowTriggerDurations, joinTTLs)` as the triggering duration. Changes in this PR: - Common Interface for all time based triggers - Additional APIs in `StreamGraphImpl` to recursively traverse all `OperatorSpec`s - Recursive computation of `triggerInterval` for each `WindowOperatorSpec` - Tests for all the above Author: vjagadish1989 <[email protected]> Reviewers: Prateek Maheshwari <[email protected]>, Jacob Maes <[email protected]>, Xinyu Liu <[email protected]> Closes apache#160 from vjagadish1989/samza-1155
This was referenced Aug 19, 2021
This was referenced Aug 26, 2021
This was referenced Sep 3, 2021
This was referenced Sep 13, 2021
This was referenced Sep 21, 2021
This was referenced Feb 3, 2022
This was referenced Feb 11, 2022
This was referenced Feb 20, 2022
This was referenced Mar 10, 2022
Merged
4 tasks
This was referenced Apr 1, 2022
This was referenced Apr 12, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a PR for easy review.