Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18178. Upgrade jackson to 2.13.2 and jackson-databind to 2.13.… #4147

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

aajisaka
Copy link
Member

@aajisaka aajisaka commented Apr 7, 2022

Description of PR

Backport HADOOP-18178 to branch-3.3 to upgrade jackson

How was this patch tested?

No manual testing

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • n/a Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…2.2 (apache#4111)

Signed-off-by: Akira Ajisaka <[email protected]>
(cherry picked from commit 4b786c7)

 Conflicts:
	LICENSE-binary
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 2s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 5m 7s Maven dependency ordering for branch
-1 ❌ mvninstall 36m 17s /branch-mvninstall-root.txt root in branch-3.3 failed.
+1 💚 compile 20m 37s branch-3.3 passed
+1 💚 mvnsite 26m 11s branch-3.3 passed
-1 ❌ javadoc 6m 27s /branch-javadoc-root.txt root in branch-3.3 failed.
+1 💚 shadedclient 30m 56s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for patch
-1 ❌ mvninstall 24m 31s /patch-mvninstall-root.txt root in the patch failed.
+1 💚 compile 17m 45s the patch passed
+1 💚 javac 17m 45s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 20m 55s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
-1 ❌ javadoc 7m 28s /patch-javadoc-root.txt root in the patch failed.
-1 ❌ shadedclient 32m 32s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 701m 1s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 20s The patch does not generate ASF License warnings.
932m 45s
Reason Tests
Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShell
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.TestReconstructStripedFileWithValidator
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
hadoop.hdfs.server.federation.router.TestRouterRpc
hadoop.yarn.sls.appmaster.TestAMSimulator
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/1/artifact/out/Dockerfile
GITHUB PR #4147
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname Linux 03a40102482c 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 65b25b8
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/1/testReport/
Max. process+thread count 2302 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

aajisaka commented Apr 9, 2022

mvninstall is failing. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/1/artifact/out/patch-mvninstall-root.txt

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-banned-dependencies) @ hadoop-client-check-test-invariants ---
[INFO] Adding ignorable dependency: org.apache.hadoop:hadoop-annotations:null
[INFO]   Adding ignore: *
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.BanDuplicateClasses failed with message:
Duplicate classes found:

  Found in:
    org.apache.hadoop:hadoop-client-minicluster:jar:3.3.3-SNAPSHOT:compile
    org.apache.hadoop:hadoop-client-runtime:jar:3.3.3-SNAPSHOT:compile
  Duplicate classes:
    META-INF/versions/9/module-info.class

We need to update the exclusion

<exclude>META-INF/versions/11/module-info.class</exclude>
because Jackson databind moved the module-info.class under versions/9 instead of versions/11.

Reference: FasterXML/jackson-bom#47

@aajisaka
Copy link
Member Author

aajisaka commented Apr 9, 2022

I'm not sure why the check passed in the PR for trunk: #4111

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 5m 5s Maven dependency ordering for branch
+1 💚 mvninstall 34m 50s branch-3.3 passed
+1 💚 compile 18m 6s branch-3.3 passed
+1 💚 mvnsite 25m 21s branch-3.3 passed
+1 💚 javadoc 7m 49s branch-3.3 passed
+1 💚 shadedclient 32m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for patch
+1 💚 mvninstall 33m 45s the patch passed
+1 💚 compile 17m 47s the patch passed
+1 💚 javac 17m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 21m 1s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 7m 32s the patch passed
+1 💚 shadedclient 32m 13s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 701m 8s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 22s The patch does not generate ASF License warnings.
927m 1s
Reason Tests
Failed junit tests hadoop.yarn.applications.distributedshell.TestDistributedShell
hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestDecommissionWithStriped
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
hadoop.hdfs.server.federation.router.TestRouterRpc
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/2/artifact/out/Dockerfile
GITHUB PR #4147
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml shellcheck shelldocs
uname Linux 7910a8799762 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 1c02694
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/2/testReport/
Max. process+thread count 2620 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4147/2/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

Failed tests

Ran successfully in my local

hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestDecommissionWithStriped

Reproduced even without the patch

hadoop.yarn.applications.distributedshell.TestDistributedShell
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer -> Filed HDFS-16536
hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
hadoop.hdfs.server.federation.router.TestRouterRpc

@aajisaka aajisaka merged commit 603367c into apache:branch-3.3 Apr 11, 2022
@aajisaka aajisaka deleted the HADOOP-18178-branch-3.3 branch April 11, 2022 05:58
asfgit pushed a commit that referenced this pull request Apr 20, 2022
…2.2 (#4147)

(cherry picked from commit 4b786c7)

 Conflicts:
	LICENSE-binary

Change-Id: I44042ade3c81a5852f1b81892ec9fbc18921a272
Co-authored-by: PJ Fanning <[email protected]>
Signed-off-by: Akira Ajisaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants