-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18131. Upgrade maven enforcer plugin and relevant dependencies #4000
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
shaded clients build is successful locally:
|
@aajisaka @jojochuang could you please review this PR? |
dev-support/Jenkinsfile
Outdated
@@ -47,7 +47,7 @@ pipeline { | |||
|
|||
options { | |||
buildDiscarder(logRotator(numToKeepStr: '5')) | |||
timeout (time: 24, unit: 'HOURS') | |||
timeout (time: 30, unit: 'HOURS') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because 24 hr is no longer sufficient for full QA run. Initial 5 builds timed out after 24 hr, hence this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you separate jira to extend the timeout to backport it into lower branches easily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Reverted the build timeout change. Created HADOOP-18142 to track extending timeout. Now that this change is reverted, we might not be able to get full QA results.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have again put this change back until we get reliable QA results again. I will revert this before merge and after getting +1 for the rest of the changes.
Thanks
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
We have full QA results from Jenkins for this PR. |
This reverts commit 387e01f.
💔 -1 overall
This message was automatically generated. |
Hi @virajjasani, thank you for the upgrade. For snappy-java, how about excluding the osgi.core dependency in the dependencyManagement section of hadoop-project/pom.xml? Perhaps there are more libraries that can be excluded in the dependencyManagement section. |
Thanks @aajisaka, yes snappy-java as well as jersey-core both can have osgi.core excluded right in the hadoop-project pom. I will test and commit the changes. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I ran the failed tests on my local. Almost all the test passed.
- TestJHSSecurity: passed
- TestRouterDistCpProcedure: passed
- TestSeveralNameNodes: passed
- TestYarnClient: passed
- TestCapacityScheduler: passed
- TestFairSchedulerQueueACLs: passed
- TestCapacitySchedulerQueueACLs: passed
- TestApplicationACLs: passed
- TestClientRMService: passed
- TestApplicationPriorityACLs: passed
- TestDSTimelineV10: passed
- TestYarnConfigurationFields: not related -> YARN-11081
This reverts commit ec1c6ce.
Is it good to merge this PR? |
I am +1 too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the nice PR, @virajjasani. Thanks for your reviews, @aajisaka and @jojochuang. |
…apache#4000) Reviewed-by: Akira Ajisaka <[email protected]> Reviewed-by: Wei-Chiu Chuang <[email protected]> Signed-off-by: Takanobu Asanuma <[email protected]>
Description of PR
Maven enforcer plugin's latest version 3.0.0 has some noticeable improvements (e.g. MENFORCER-350, MENFORCER-388, MENFORCER-353) and fixes for us to incorporate. Besides, some of the relevant enforcer dependencies (e.g. extra enforcer rules and restrict import enforcer) too have good improvements.
We should upgrade maven enforcer plugin and the relevant dependencies.
How was this patch tested?
Locally
For code changes: