Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct set analysis tech entry behavior breaking change #504

Merged

Conversation

MrPurple6411
Copy link
Member

Changes made in this pull request

  • It's almost 2am and I have to work in the morning. Remind me to write this when I get home tomorrow.

…ew ALL aspects of the ScannerGadget PR.

Fix: Corrected removals timing
Doc: Added more notes to describe the why things are where they are.
Doc: Added notes on methods that modify instead of replace even if the name is horrible and makes you think they should replace.
@MrPurple6411 MrPurple6411 merged commit 718fb56 into master Dec 17, 2023
3 checks passed
@MrPurple6411 MrPurple6411 deleted the Correct-SetAnalysisTechEntry-behavior-breaking-change- branch December 17, 2023 22:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant