-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMLHelper 2.11 #235
Merged
SMLHelper 2.11 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoice` was incorrectly displaying the choice as if the first option was selected when the menu is first built, regardless of what option is actually selected.
…es-bugfix Menu options showing incorrect chosen value for enum-based `[Choice]` when using custom `string` names.
…lder` until the options menu has been successfully registered and the `ConfigFile` has been returned to the API consumer.
…aHandler` that can be used to automatically read/write to from a json file that is per-mod-per-save.
…t to `false`. Improved comments.
…bute-events Defer `ConfigFile` attribute-based events when using the `OptionsMenuBuilder` via `RegisterModOptions<ConfigFile>`.
…er than deep storage, and reverted the change to createFileIfNotExist.
…taCache, and changed the way it handles updating the player position to utilise the OnStartedSaving etc. events of SaveDataCache, inherited from JsonFile.
…since for this mod they will work just fine as variables within the `Patch` method.
…for the saved file if you backed out to the main menu and loaded the game again, preventing the CoordinatesSpawnsInitialized.smlhelper file from being saved.
…lized-bugfix `CoodinatedSpawnsInitialized.smlhelper` bugfix
…sIncludedConverters` of `JsonFile`, and subsequently removing the override from `SaveDataCache` that adds these converters.
…ache Add a base `JsonFile` implementation for extension, as well as a `SaveDataCache` extension of `JsonFile` for working with per-mod-per-saveslot cached data
…ncludedConverters` of `ConfigFile`.
…-and-quaternion-converters Add `Vector3Converter` and `QuaternionConverter` to `ConfigFile`
Builds 00a9fe3SubnauticaStableExperimentalBelow ZeroStableExperimental |
PrimeSonic
approved these changes
Jul 13, 2021
Metious
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this version
This is a backwards-compatible feature release.
JsonFile
implementation for extension, as well as aSaveDataCache
extension ofJsonFile
for working with per-mod-per-saveslot cached data #233JsonFile
to theSMLHelper.V2.Json
namespace. This is a very basic implementation ofIJsonFile
, intended for use for saving and loading simple json files, and can be extended as needed for custom purposes.SaveDataCache
to theSMLHelper.V2.Json
namespace, which extends from the newJsonFile
class. This abstract class is intended to be used in a similar manner asConfigFile
, but for the purpose of per-mod-per-save data. See the linked PR for more details and example usages.SaveDataHandler
for registering aSaveDataCache
with SMLHelper to be automatically saved/loaded to/from disk when appropriate.InGameMenuHandler
that provide the ability to register callbacks with SMLHelper to be invoked whenever a game is loaded, similar to the methods it already provides that invoke a callback when the user saves or quits the game.SaveDataCache
andSaveDataHandler
features.Vector3Converter
andQuaternionConverter
toConfigFile
#236Vector3Converter
andQuaternionConverter
to theAlwaysIncludedConverters
ofConfigFile
implementations.[Choice]
when using customstring
names. #231string
names for enum-basedChoice
was incorrectly displaying the choice as if the first option was selected when the menu is first built, regardless of what option is actually selected.CoodinatedSpawnsInitialized.smlhelper
bugfix #234CoordinatedSpawnsInitialized.smlhelper
not being correctly saved when the player saves the game.ConfigFile
attribute-based events when using theOptionsMenuBuilder
viaRegisterModOptions<ConfigFile>
. #232ConfigFile
attribute-based events are now deferred until theOptionsPanelHandler
has finished registering theConfigFile
to the options menu to ensure consistency across allConfigFile
events.Builds v2.10.1.2 00a9fe3
Subnautica
Stable
SMLHelper
Example Mod
Experimental
SMLHelper
Example Mod
Below Zero
Stable
SMLHelper Zero
Example Mod
Experimental
SMLHelper Zero
Example Mod