Defer ConfigFile attribute-based events when using the OptionsMenuBuilder via RegisterModOptions<ConfigFile>.
#232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder` until the options menu has been successfully registered and the `ConfigFile` has been returned to the API consumer.
PrimeSonic
approved these changes
Jul 9, 2021
Merged
toebeann
added a commit
that referenced
this pull request
Jul 25, 2021
…ing fired due to a missing `case` in the event router. 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
ConfigFiles making use of theOptionsMenuBuilderuntil the options menu has been successfully registered and theConfigFilehas been returned to the API consumer.This is implemented by way of checking whether we have yet marked the options menu as being registered, and if not, wait until the first frame where it has been marked as registered, using UnityEngine's coroutines.
This enables consistency in all events - the API consumer can be sure that the
ConfigFileinstance has been passed back to them for use.Builds de044d1
Subnautica
Stable
Experimental
Below Zero
Stable
Experimental