Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vector3Converter and QuaternionConverter to ConfigFile #236

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Add Vector3Converter and QuaternionConverter to ConfigFile #236

merged 1 commit into from
Jul 12, 2021

Conversation

toebeann
Copy link
Contributor

Changes made in this pull request

  • Adds the Vector3Converter and QuaternionConverter to the AlwaysIncludedConverters of ConfigFile implementations. This should resolve any issues that API consumers may have had with attempting to include Vector3 or Quaternion members in ConfigFile implementations.

@toebeann toebeann self-assigned this Jul 12, 2021
@toebeann toebeann merged commit 8ac60ec into dev Jul 12, 2021
@toebeann toebeann deleted the configfile-add-vector3-and-quaternion-converters branch July 12, 2021 16:18
@toebeann toebeann mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPurple6411 MrPurple6411 Awaiting requested review from MrPurple6411

@PrimeSonic PrimeSonic Awaiting requested review from PrimeSonic

@Metious Metious Awaiting requested review from Metious

Assignees

@toebeann toebeann

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toebeann