-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESPN] Include additional URL formats (fixes issue #13244) #13549
Changes from 5 commits
72da97c
3f21e1e
0f427b1
1dc4bc1
cf70113
da12ebc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,19 @@ | |
|
||
|
||
class ESPNIE(InfoExtractor): | ||
_VALID_URL = r'https?://(?:espn\.go|(?:www\.)?espn)\.com/video/clip(?:\?.*?\bid=|/_/id/)(?P<id>\d+)' | ||
_VALID_URL = r'''(?x) | ||
https?:// | ||
(?: | ||
(?:(?:\w+\.)+)?espn\.go| | ||
(?:www\.)?espn | ||
)\.com/ | ||
(?: | ||
video/clip(?:\?.*?\bid=|/_/id/)| | ||
watch/player(?:\?.*?\bid=|/_/id/) | ||
) | ||
(?P<id>\d+) | ||
''' | ||
|
||
_TESTS = [{ | ||
'url': 'http://espn.go.com/video/clip?id=10365079', | ||
'info_dict': { | ||
|
@@ -25,20 +37,34 @@ class ESPNIE(InfoExtractor): | |
'skip_download': True, | ||
}, | ||
}, { | ||
# intl video, from http://www.espnfc.us/video/mls-highlights/150/video/2743663/must-see-moments-best-of-the-mls-season | ||
'url': 'http://espn.go.com/video/clip?id=2743663', | ||
'url': 'https://broadband.espn.go.com/video/clip?id=18910086', | ||
'info_dict': { | ||
'id': '2743663', | ||
'id': '18910086', | ||
'ext': 'mp4', | ||
'title': 'Must-See Moments: Best of the MLS season', | ||
'description': 'md5:4c2d7232beaea572632bec41004f0aeb', | ||
'timestamp': 1449446454, | ||
'upload_date': '20151207', | ||
'title': 'Kyrie spins around defender for two', | ||
'description': 'md5:2b0f5bae9616d26fba8808350f0d2b9b', | ||
'timestamp': 1489539155, | ||
'upload_date': '20170315', | ||
}, | ||
'params': { | ||
'skip_download': True, | ||
}, | ||
'expected_warnings': ['Unable to download f4m manifest'], | ||
}, { | ||
'url': 'http://nonredline.sports.espn.go.com/video/clip?id=19744672', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'only_matching': True, | ||
}, { | ||
'url': 'https://cdn.espn.go.com/video/clip/_/id/19771774', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'only_matching': True, | ||
}, { | ||
'url': 'http://www.espn.com/watch/player?id=19141491', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'only_matching': True, | ||
}, { | ||
'url': 'http://www.espn.com/watch/player?bucketId=257&id=19505875', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'only_matching': True, | ||
}, { | ||
'url': 'http://www.espn.com/watch/player/_/id/19141491', | ||
'only_matching': True, | ||
}, { | ||
'url': 'http://www.espn.com/video/clip?id=10365079', | ||
'only_matching': True, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code duplication.