[ESPN] Include additional URL formats (fixes issue #13244) #13549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jul 3, 2017
youtube_dl/extractor/espn.py
Outdated
| @@ -10,7 +10,7 @@ | |||
|
|
|||
|
|
|||
| class ESPNIE(InfoExtractor): | |||
| _VALID_URL = r'https?://(?:espn\.go|(?:www\.)?espn)\.com/video/clip(?:\?.*?\bid=|/_/id/)(?P<id>\d+)' | |||
| _VALID_URL = r'https?://(?:(?:(\w+\.)+)?espn\.go|(?:www\.)?espn)\.com/(?:video/clip(?:\?.*?\bid=|/_/id/)|watch/player\?.*?\bid=)(?P<id>\d+)' | |||
There was a problem hiding this comment.
(\w+\.)is captured for no purpose.- It's probably time to make regex verbose
(?x).
youtube_dl/extractor/espn.py
Outdated
| }, | ||
| 'expected_warnings': ['Unable to download f4m manifest'], | ||
| }, { | ||
| 'url': 'http://nonredline.sports.espn.go.com/video/clip?id=19744672', |
youtube_dl/extractor/espn.py
Outdated
| }, | ||
| 'expected_warnings': ['Unable to download f4m manifest'], | ||
| }, { | ||
| 'url': 'https://cdn.espn.go.com/video/clip/_/id/19771774', |
youtube_dl/extractor/espn.py
Outdated
| }, | ||
| 'expected_warnings': ['Unable to download f4m manifest'], | ||
| }, { | ||
| 'url': 'http://www.espn.com/watch/player?id=19141491', |
youtube_dl/extractor/espn.py
Outdated
| }, | ||
| 'expected_warnings': ['Unable to download f4m manifest'], | ||
| }, { | ||
| 'url': 'http://www.espn.com/watch/player?bucketId=257&id=19505875', |
|
I have applied the requested fixes, please review at your convenience. Thanks! |
|
Shall I make any further corrections for this PR? Thank you! |
dstftw
requested changes
Jul 5, 2017
youtube_dl/extractor/espn.py
Outdated
| )\.com/ | ||
| (?: | ||
| video/clip(?:\?.*?\bid=|/_/id/)| | ||
| watch/player\?.*?\bid= |
There was a problem hiding this comment.
Does not cover http://www.espn.com/watch/player/_/id/19141491.
dstftw
requested changes
Jul 5, 2017
youtube_dl/extractor/espn.py
Outdated
| )\.com/ | ||
| (?: | ||
| video/clip(?:\?.*?\bid=|/_/id/)| | ||
| watch/player(?:\?.*?\bid=|/_/id/) |
|
Good catch - I have updated the regex and added this URL to the test suite for this extractor. Please let me know if there are any other issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Updated the regex for the [ESPN] extractor to include additional URL formats for videos featured on the site - issue #13244.
Cheers,
Parmjit V.