Obey ip argument and only bind to given address. #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously since no address was given to the tornado listen call the voila application listens on all interfaces.
|
Thanks @adament!
Adding to the 0.3.0 milestone for consideration. |
|
Thank @adament, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously since no address was given to the tornado listen call the
voila application listens on all interfaces.
References
I have not opened an issue for this and could not find one when I quickly looked.
Code changes
Simply change the call to tornado.web.Application.listen so that it passes along the Voila.ip parameter as the address argument.
User-facing changes
If people previously relied on voila by default binding to all interfaces they will now experience a backwards compatibility break, the backwards compatibility can be preserved by changing the default value of ip to '0.0.0.0' (which is what it actually was). Personally I do however believe that the previous behaviour was a security issue (binding on all interfaces while claiming to bind only to localhost) and should be fixed, and users should explicitly opt in to binding to more than localhost. But I understand if preserving backwards compatibility is to preferred.
Backwards-incompatible changes
Same as User-facing changes.