add computed or given ip address or hostname to tornado init #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
reviewed
Oct 20, 2021
| @@ -566,7 +566,7 @@ def listen(self): | |||
| success = False | |||
| for port in self.random_ports(self.port, self.port_retries+1): | |||
| try: | |||
| self.app.listen(port) | |||
| self.app.listen(port,address=self.ip) | |||
There was a problem hiding this comment.
Thank you very much for your contribution! A minor code format problem:
Suggested change
| self.app.listen(port,address=self.ip) | |
| self.app.listen(port, address=self.ip) |
|
Thank @athivillon for your contribution, I close this PR since #926 is merged with the same feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voila.ip is documented as "--Voila.ip=
The IP address the notebook server will listen on.
Default: 'localhost'
"
But this is false, Tornado is listening on all interfaces, including public ones, even if we use 127.0.0.1. In my opinion, this is a huge security risk, at least for using Voila on servers having Internet access.
This patch initialises Tornado with address option filled with ip computed or passed on command-line.