-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt monorepo structure #808
Conversation
cc @martinRenou if you want to review, since you've also been looking at similar structures and build systems recently. The idea would be to merge this PR first before migrating to TypeScript for the Voila frontend. |
Sorry I missed the notification, LGTM 👍🏼 |
Reverted back to the commit where CI was passing: 0108d27: Need to investigate why the Voila tests suddenly started to fail now. |
Tests are green again with the pin to |
I think it's fine to pin to |
OK sounds good, thanks for the heads-up 👍 We can open a new issue to remember to unpin at some point in the future. |
Thanks Martin and Johan! Looks good now, so we can merge and iterate in follow-up PRs. |
Opened #812 to keep track of the unpin. |
Adopt a monorepo structure with
lerna
to streamline the build process, and align the setup with current practices also used in other repos.This makes it easier to build the packages with a single streamlined workflow:
This is in preparation for switching to TypeScript for the Voila frontend, and to the lab 3 based frontend later on.
TODO
setup.py
packages/voila