Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview extension: switch to LabIcon for the Voila icon #755

Closed
jtpio opened this issue Oct 30, 2020 · 1 comment
Closed

Preview extension: switch to LabIcon for the Voila icon #755

jtpio opened this issue Oct 30, 2020 · 1 comment
Labels
jupyterlab-preview JupyterLab Preview Extension

Comments

@jtpio
Copy link
Member

jtpio commented Oct 30, 2020

Similar to #620, but for the Voila icons:

image

image

The @jupyter-voila/jupyterlab-preview could define the Voila icon as a LabIcon and export it, so other plugins could reuse it.

We would need to check whether LabIcon supports two versions for an icon (if we want to keep both the light as dark versions as is), or if that would mean keeping only one (potentially modified) and let lab handle the theming.
@jtpio jtpio added the jupyterlab-preview JupyterLab Preview Extension label Oct 30, 2020
@jtpio jtpio mentioned this issue Jan 21, 2021
Merged
5 tasks
@jtpio
Copy link
Member Author

jtpio commented Jan 21, 2021

Fixed by #808

@jtpio jtpio closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jupyterlab-preview JupyterLab Preview Extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtpio