Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vrl): Update documentation for community_id to mention ICMP #20677

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

jszwedko
Copy link
Member

The source port and dest port arguments are overloaded for ICMP, which is layer 3 and so has no concept of ports.

Ref: vectordotdev/vrl#891

The source port and dest port arguments are overloaded for ICMP, which is layer 3 and so has no
concept of ports,

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jun 14, 2024
@jszwedko jszwedko requested review from a team as code owners June 14, 2024 20:37
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jun 14, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/document-community-id-icmp
Commit report: 1e5a405
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.53s Total Time

@jszwedko jszwedko enabled auto-merge June 20, 2024 13:13
@jszwedko jszwedko disabled auto-merge June 20, 2024 13:13
@jszwedko jszwedko enabled auto-merge July 10, 2024 13:49
@jszwedko jszwedko added this pull request to the merge queue Jul 10, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/document-community-id-icmp
Commit report: c07f335
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

Merged via the queue into master with commit e52f312 Jul 10, 2024
50 checks passed
@jszwedko jszwedko deleted the jszwedko/document-community-id-icmp branch July 10, 2024 18:54
ym pushed a commit to ym/vector that referenced this pull request Aug 18, 2024
…tordotdev#20677)

The source port and dest port arguments are overloaded for ICMP, which is layer 3 and so has no
concept of ports,

Signed-off-by: Jesse Szwedko <[email protected]>
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
…tordotdev#20677)

The source port and dest port arguments are overloaded for ICMP, which is layer 3 and so has no
concept of ports,

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants