Community ID is incorrect for ICMP

[DylanRJohnston]

I've let the upstream library know of the problem, but I thought you guys might also be interested in the problem. traceflight/rs-community-id#3

[jszwedko]

Thanks! We'll track the upstream issue.

[DylanRJohnston]

I've got a pull request up to fix the issue traceflight/rs-community-id#4

[DylanRJohnston]

I also think the documentation needs to be updated on the community_id function to point out that source_port and destination_port for ICMP are actually and ICMP type and ICMP code respectively. This was very confusing when I was first investigating the issue, especially as Elastic Search separates those arguments. Perhaps it would be wise to do the same as semantic overloading of named arguments is very confusing. Although if you wanted to introduce a more accurate error message this would be a breaking change.

[DylanRJohnston]

Found further problems with the handling of ICMP with IPv6 addresses traceflight/rs-community-id#5

[jszwedko]

Nice, thanks @DylanRJohnston, good finds.

The overloading of port to be ICMP type and code is a bit confusing. I see that, for example, the Go library has separate functions per level 4 protocol and also ICMP. We could do something similar. Notably the C implementation seems to also overload like we are. I'll open a PR to update the docs for now at least.

[jszwedko]

Docs update: vectordotdev/vector#20677

[traceflight]

Thanks @DylanRJohnston. I have released a new version of rs-community-id. Feel free to mention me if any issue found~