Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Application Default Credential if gcp.credential is absent #1531

Closed
wants to merge 31 commits into from
Closed

Use Application Default Credential if gcp.credential is absent #1531

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a226c75
Set version to 0.11.0-SNAPSHOT
Dec 15, 2020
d9fe89e
Add v0_11 as the target of CI.
Dec 16, 2020
f078faf
Merge pull request #1504 from yoyama/v0_11_fix-version
yoyama Dec 16, 2020
d1e3578
Fix CI to release snapshot for v0_11 branch.
Dec 16, 2020
f8dda61
Merge pull request #1505 from yoyama/v0_11-fix-ci-release-snapshot
yoyama Dec 16, 2020
f5a1dc7
Exclude v0_10 branch from snapshot release
Dec 21, 2020
c978727
Merge pull request #1508 from yoyama/disable-snapshot-release-of-v0_1…
yoyama Dec 21, 2020
fc02db4
Set `started_at` in group tasks as well.
komamitsu Jan 8, 2021
9abf713
Add some comments
komamitsu Jan 12, 2021
9fae04a
Merge pull request #1518 from treasure-data/started_at-in-group-tasks
komamitsu Jan 12, 2021
9206279
Add 'wait' operator
komamitsu Jan 12, 2021
68c16fe
Add test for `wait` operator
komamitsu Jan 14, 2021
4d00284
Add description about `wait` operator
komamitsu Jan 14, 2021
56e349d
Refactoring
komamitsu Jan 14, 2021
fc87d47
Add `blocking` and `poll_interval` options
komamitsu Jan 15, 2021
e9343cb
Small refactoring
komamitsu Jan 15, 2021
bc268c1
Replace nullable value with Optional
komamitsu Jan 15, 2021
a7a01db
Make the key name clearer
komamitsu Jan 15, 2021
52c411a
Fix typo
komamitsu Jan 15, 2021
d61a7bd
Add missing test case
komamitsu Jan 15, 2021
162c686
Refactoring
komamitsu Jan 21, 2021
81e3b72
Use a safer expected value
komamitsu Jan 21, 2021
cc7260e
Merge pull request #1520 from treasure-data/wait-oprator
komamitsu Jan 21, 2021
b7562ff
use application default credential if gcp.credential is absent
rhase Feb 2, 2021
15d3da3
fixed indentation
rhase Feb 4, 2021
a053642
add test
rhase Feb 16, 2021
2c3f593
fix indentation
rhase Feb 16, 2021
5c9a981
bugfix
rhase Feb 16, 2021
0c2e9a1
consideration for windows
rhase Feb 16, 2021
532b6df
organize imports
rhase Feb 16, 2021
ee00c6d
Merge branch 'master' into feature/use-gcp-application-default-creden…
rhase May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bugfix
  • Loading branch information
@rhase
rhase committed Feb 16, 2021
commit 5c9a9816383db8b289d157fd0bef96f3d8f76b08
2 changes: 1 addition & 1 deletion digdag-standards/src/main/java/io/digdag/standards/operator/gcp/GcpCredentialProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ GcpCredential credential(SecretProvider secrets)
builder.projectId(ServiceOptions.getDefaultProjectId())
.credential(GoogleCredential.getApplicationDefault());
}
catch (IOException e) {
catch (Exception e) {
throw new TaskExecutionException(
"Could not get google cloud credential: need gcp.credential secret or Application Default Credentials",
e
Expand Down