Use Application Default Credential if gcp.credential is absent #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set version to 0.11.0-SNAPSHOT Include treasure-data#1502 to run CI.
…e-snapshot v0_11 fix CI on release of snapshot
…lease-of-v0_10-for-v0_11 [V0_11] Disable snapshot release of v0_10
But just doing that would change current task TTL timeout behavior. So, this commit also takes care of it.
…n-group-tasks Set `started_at` in group tasks as well
to `wait` operator
Add `wait` operator by porting https://github.com/yoyama/digdag-wait-op
|
Thank you for your contribution. |
|
@yoyama |
|
@rhase Thank you for adding test cases. Looks good to me 👍 BTW, could you update the target branch to |
|
I tried to change target branch by "Edit" button of this PR, but that seems to have caused unexpected effect... |
|
recreated as #1585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes
Use Application Default Credential (ADC) if gcp.credential secret is not defined.
Applied to bq, bq_ddl, bq_load, bq_extract and gcs_wait.
Motivation
It's very convenient to use ADC when you run digdag on gce or gke because you don't have to manage service account credentials by your self (Google will manage them for you).
You can also test workflow on your machine with your google account by
gcloud auth application-default login. You don't need service account and gcp.credential secret.