Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: mark PCL and YAML_CPP as SYSTEM #96

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Nov 16, 2023

PR Type

  • Bug Fix

Related Links

Closes:

Description

See the issue.

Review Procedure

Here are the warnings from the nebula repo CI without this PR:

You can check the CI build logs and see if the warnings are gone.

Also the total lines in the build output went from 6438 -> 5440, 1000 line reduction.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz self-requested a review November 16, 2023 15:10
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drwnz drwnz merged commit 7ae8cf5 into tier4:main Nov 16, 2023
8 of 9 checks passed
@xmfcx xmfcx deleted the build/mark-libs-as-system branch November 17, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants