Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename transport_drivers to boost_transport_driver #46

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Aug 7, 2023

PR Type

  • Improvement

Related Links

https://tier4.atlassian.net/browse/RT1-3373?atlOrigin=eyJpIjoiODU3ZmM4ZjA4MGRhNGMzM2ExOTJjZGI3ZTM4MmYyYWMiLCJwIjoiaiJ9

Description

Rename TCP/HTTP-enabled transport_drivers package to avoid conflicts with the existing transport_drivers package.

Review Procedure

  • Clone this branch
  • Switch to the boost branch for transport_drivers.
  • Compile Nebula
  • Run tests
  • Test Nebula decoders with actual sensor(s).

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -5.78% ⚠️

Comparison is base (189d7e2) 13.38% compared to head (f4a1171) 7.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##             main     #46      +/-   ##
=========================================
- Coverage   13.38%   7.61%   -5.78%     
=========================================
  Files         111      36      -75     
  Lines       10990    6831    -4159     
  Branches     1727    1145     -582     
=========================================
- Hits         1471     520     -951     
+ Misses       8338    5368    -2970     
+ Partials     1181     943     -238     
Flag Coverage Δ
differential 7.61% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ebula_ros/hesai/hesai_hw_interface_ros_wrapper.hpp 0.00% <ø> (ø)
.../nebula_ros/hesai/hesai_hw_monitor_ros_wrapper.hpp 0.00% <ø> (ø)
...ula_ros/src/hesai/hesai_hw_monitor_ros_wrapper.cpp 0.00% <ø> (ø)

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: amc-nu <[email protected]>
@amc-nu amc-nu changed the title rename transport_drivers to boost_transport_driver refactor: rename transport_drivers to boost_transport_driver Aug 7, 2023
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants