Add a few diagnostics for variadic generic types #65767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are just temporary limitations.
slavapestov
force-pushed
the
variadic-generic-diagnostics
branch
from
104af9f
to
8f71dc9
Compare
|
@swift-ci Please test |
xedin
reviewed
May 8, 2023
| @@ -5432,7 +5438,7 @@ ERROR(pack_reference_must_be_in_expansion,none, | |||
| "pack reference %0 requires expansion using keyword 'repeat'", | |||
| (TypeRepr*)) | |||
| ERROR(pack_type_requires_keyword_each,none, | |||
| "pack type %0 must be referenced with 'each'", | |||
| "type pack %0 must be referenced with 'each'", | |||
There was a problem hiding this comment.
Heh, I have made this change in #65718 too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variadic generic type cannot declare more than one pack in its generic parameter list. This is an intentional restriction in the design.
Also the current implementation does not support variadic enums, or inheritance from variadic classes. These last two will go away eventually.