[ConstraintSystem] Detect and diagnose missing 'each' and provide a fix-it #65718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS |
|
@swift-ci please test |
This is going to help us identify and fix positions were 'each' keyword is mising.
Diagnose situations where value pack is referenced without an explicit 'each':
```
func compute<each T>(_: repeat each T) {}
func test<each T>(v: repeat each T) {
repeat compute(v) // should be `repeat compute(each v)`
}
```
…ference Detect that a value pack is missing 'each' keyword during constraint generation and fix-it by injecting `PackElementExpr`.
xedin
force-pushed
the
diagnose-missing-each-in-expr-context
branch
from
1ad71ee
to
e3d1317
Compare
|
Dropped the change |
|
@swift-ci please test |
hborla
approved these changes
May 15, 2023
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose situations where value pack is referenced without an explicit 'each':