Update CRA Webpack configuration path #5079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appbak3r
reviewed
Dec 24, 2018
app/react/src/server/cra-config.js
Outdated
| @@ -81,8 +81,7 @@ export const getTypeScriptRules = (webpackConfigRules, configDir) => { | |||
| export function getCraWebpackConfig(mode) { | |||
| const pathToReactScripts = getReactScriptsPath(); | |||
|
|
|||
| const craWebpackConfig = | |||
| mode === 'production' ? 'config/webpack.config.prod' : 'config/webpack.config.dev'; | |||
| const craWebpackConfig = 'config/webpack.config'; | |||
There was a problem hiding this comment.
I guess I shouldn't do that due to backward compatibility with older versions of CRA and react-scripts
There was a problem hiding this comment.
I've added a check for this. Let's see if CI passes.
Codecov Report
@@ Coverage Diff @@
## next #5079 +/- ##
=======================================
Coverage 35.06% 35.06%
=======================================
Files 593 593
Lines 7347 7347
Branches 1005 1004 -1
=======================================
Hits 2576 2576
- Misses 4258 4259 +1
+ Partials 513 512 -1
Continue to review full report at Codecov.
|
|
This is a duplicate of #5074. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5077
What I did
I have updated
cra-config.jsto handle the Webpack configuration merge in CRA 2.1.2. This breaks projects running an older version of CRA. Shouldcra-kitchen-sinkbe updated to reflect this?Related PR: #5074
How to test
Run Storybook in a project with version 2.1.2 of
react-scriptsin its dependencies.