Merge webpack configuration #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question: would CRA eject with new webpack configuration? |
|
Yes, ejecting would give you this new configuration and it'd work. Do you have a concern? |
ianschmitz
reviewed
Nov 6, 2018
ianschmitz
reviewed
Nov 6, 2018
ianschmitz
reviewed
Nov 6, 2018
|
YOLO, what could go wrong? |
andykenward
pushed a commit
to Stinkstudios/npm-packages
that referenced
this pull request
Nov 9, 2018
Taken from - facebook/create-react-app@30ee52c - facebook/create-react-app#5722 But adjusted to match our needs
andykenward
pushed a commit
to Stinkstudios/npm-packages
that referenced
this pull request
Nov 9, 2018
Taken from - facebook/create-react-app@30ee52c - facebook/create-react-app#5722 But adjusted to match our needs
xs9627
pushed a commit
to xs9627/create-react-app
that referenced
this pull request
Nov 12, 2018
* facebook-master: (578 commits) Add PR welcoming badge (facebook#5759) Suggest Encore when not building a SPA with Symfony (facebook#5730) Merge webpack configuration (facebook#5722) Tweak bot settings Update stale.yml Fix typo (facebook#5727) Version bump postcss-preset-env to latest (facebook#5721) Updated the link to firebase hosting (facebook#5710) Fixed link to manifest.json file (facebook#5704) Fix broken documentation link (facebook#5670) Fix tsconfig.json lib suggested value (facebook#5701) Add permissive TS lib defaults (facebook#5694) Lock issues more aggressively Make stale bot configuration more aggressive ignore intellij module files when generating an app (facebook#4605) update envinfo to 5.11.1 (facebook#5685) Add bot config (facebook#4483) Publish Update cached lock file Add changelog for 2.1.1 ...
andykenward
pushed a commit
to Stinkstudios/npm-packages
that referenced
this pull request
Nov 13, 2018
Taken from - facebook/create-react-app@30ee52c - facebook/create-react-app#5722 But adjusted to match our needs
andykenward
pushed a commit
to Stinkstudios/npm-packages
that referenced
this pull request
Nov 13, 2018
Taken from - facebook/create-react-app@30ee52c - facebook/create-react-app#5722 But adjusted to match our needs
mrmckeb
pushed a commit
to BeameryHQ/bmr-react-scripts
that referenced
this pull request
Nov 19, 2018
* Rename production configuration * Upgrade lint staged * Merge mode, bail, devtool, and entry * Merge output settings * Remove old comment * Merge some trivial differences * Disable minimize in development mode * Only minify html and generate SW in production * Adjust comment * Toggle development plugins * Add missing imports * Scope settings * Delete development config * Use new config file * Remove unnecessary config import
kaltepeter
added a commit
to kaltepeter/cra-build-watch
that referenced
this pull request
Dec 24, 2018
kaltepeter
added a commit
to kaltepeter/cra-build-watch
that referenced
this pull request
Dec 24, 2018
1 task
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the configuration easier to update (reduces duplication).
Follows webpack 4 convention of configuration as a function, accepting
envas first argument. Will work with CLI invokes.Let's see if this passes tests ...