-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'Community admins will review your request' text from community overview screen #19361
Remove 'Community admins will review your request' text from community overview screen #19361
Conversation
@@ -235,7 +235,6 @@ | |||
"membership-title": "Membership requirement", | |||
"create-channel-title": "New channel", | |||
"edit-channel-title": "Edit channel", | |||
"community-admins-will-review-your-request": "Community admins will review your request", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this translation key is being used in e2e tests here:
"community-admins-will-review-your-request").is_element_displayed(10): |
I'm not familiar with this code. Should I do anything about this?
cc: @yevh-berdnyk / @status-im/mobile-qa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ajayesivan, thanks for letting us know! I've just pushed an update for e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Jenkins BuildsClick to see older builds (8)
|
75% of end-end tests have passed
Failed tests (11)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (36)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
|
81% of end-end tests have passed
Failed tests (8)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
|
12% of end-end tests have passed
Failed tests (7)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
|
Thanks for the fixes @ajayesivan ! |
3331e50
to
53878ab
Compare
…y overview screen (#19361) * Remove 'Community admins will review your request' text from community overview screen * Use the button label 'Request to join' for all communities * e2e: updated test --------- Co-authored-by: Yevheniia Berdnyk <[email protected]>
…y overview screen (#19361) * Remove 'Community admins will review your request' text from community overview screen * Use the button label 'Request to join' for all communities * e2e: updated test --------- Co-authored-by: Yevheniia Berdnyk <[email protected]>
fixes #19354
fixes #19355
status: ready