Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint for Logup claimed cumsum #830

Open
wants to merge 1 commit into
base: 09-09-Logup_generator_returns_multiple_prefix_sums
Choose a base branch
from

Conversation

shaharsamocha7
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 commented Sep 10, 2024

Add optional constraint for logup claimed sum
The constraint applies only in case that the claimed_sum is not the total sum
Uses for padding components with default rows


This change is Reviewable

Copy link
Collaborator Author

shaharsamocha7 commented Sep 10, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shaharsamocha7 and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (b3f754b) to head (62fbf19).

Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           09-09-Logup_generator_returns_multiple_prefix_sums     #830      +/-   ##
======================================================================================
+ Coverage                                               92.71%   92.78%   +0.06%     
======================================================================================
  Files                                                      89       89              
  Lines                                                   12036    12050      +14     
  Branches                                                12036    12050      +14     
======================================================================================
+ Hits                                                    11159    11180      +21     
+ Misses                                                    770      763       -7     
  Partials                                                  107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaharsamocha7 shaharsamocha7 force-pushed the 09-09-Logup_generator_returns_multiple_prefix_sums branch from b3f754b to 4c3990c Compare September 17, 2024 11:01
@shaharsamocha7 shaharsamocha7 force-pushed the 09-10-Add_constraint_for_Logup_claimed_cumsum branch from 62fbf19 to 536f8f9 Compare September 17, 2024 11:01
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)


crates/prover/src/constraint_framework/logup.rs line 84 at r2 (raw file):

            Some((claimed_sum, claimed_row_index)) => {
                let [cur_cumsum, prev_row_cumsum, claimed_cumsum] = eval
                    .next_extension_interaction_mask(self.interaction, [0, -1, claimed_row_index]);

It's more efficient using is_first column and doing the constraint with cur_cumsum and a row selector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants