-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraint for Logup claimed cumsum #830
base: 09-09-Logup_generator_returns_multiple_prefix_sums
Are you sure you want to change the base?
Add constraint for Logup claimed cumsum #830
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shaharsamocha7 and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-09-Logup_generator_returns_multiple_prefix_sums #830 +/- ##
======================================================================================
+ Coverage 92.71% 92.78% +0.06%
======================================================================================
Files 89 89
Lines 12036 12050 +14
Branches 12036 12050 +14
======================================================================================
+ Hits 11159 11180 +21
+ Misses 770 763 -7
Partials 107 107 ☔ View full report in Codecov by Sentry. |
b3f754b
to
4c3990c
Compare
62fbf19
to
536f8f9
Compare
4c3990c
to
45206e8
Compare
536f8f9
to
da54d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)
crates/prover/src/constraint_framework/logup.rs
line 84 at r2 (raw file):
Some((claimed_sum, claimed_row_index)) => { let [cur_cumsum, prev_row_cumsum, claimed_cumsum] = eval .next_extension_interaction_mask(self.interaction, [0, -1, claimed_row_index]);
It's more efficient using is_first
column and doing the constraint with cur_cumsum
and a row selector
Add optional constraint for logup claimed sum
The constraint applies only in case that the claimed_sum is not the total sum
Uses for padding components with default rows
This change is