Logup generator returns multiple prefix sums #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shaharsamocha7 and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column #829 +/- ##
=================================================================================================================
Coverage 91.81% 91.81%
=================================================================================================================
Files 89 89
Lines 12082 12088 +6
Branches 12082 12088 +6
=================================================================================================================
+ Hits 11093 11099 +6
Misses 882 882
Partials 107 107 ☔ View full report in Codecov by Sentry. |
shaharsamocha7
force-pushed
the
09-09-Logup_generator_returns_multiple_prefix_sums
branch
from
d50d61f
to
b3f754b
Compare
shaharsamocha7
force-pushed
the
09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column
branch
from
483abed
to
4095bd6
Compare
shaharsamocha7
force-pushed
the
09-09-Logup_generator_returns_multiple_prefix_sums
branch
from
b3f754b
to
4c3990c
Compare
shaharsamocha7
force-pushed
the
09-08-Logup_-_rename_claimed_sum_to_total_sum_Take_total_sum_from_cum_sum_column
branch
from
4095bd6
to
f465a76
Compare
shaharsamocha7
force-pushed
the
09-09-Logup_generator_returns_multiple_prefix_sums
branch
from
4c3990c
to
45206e8
Compare
This was referenced Sep 18, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logup generator finalize get a list of indices and returns the corresponding prefix sum
This change is