Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scully): support for markdown options like {:target="_blank"} #422

Merged
merged 3 commits into from
Mar 24, 2020
Merged

feat(scully): support for markdown options like {:target="_blank"} #422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b0a78c
feat(scully): support for markdown options like `{:target="_blank"}`
SanderElias Mar 24, 2020
9bd8ce6
test(scully): add e2e test for customMarkdownOptions
SanderElias Mar 24, 2020
33afd21
refactor(scully): remove comment
SanderElias Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(scully): add e2e test for customMarkdownOptions
  • Loading branch information
@SanderElias
SanderElias committed Mar 24, 2020
commit 9bd8ce6ff46b73164424ed66d246ee3d5d9d5e76
2 changes: 2 additions & 0 deletions blog/page-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ slugs:

## its a wild world after all

Link to [angular](http://angular.io){:target=\_blank}

```typescript
console.log('amazing');
```
Expand Down
7 changes: 6 additions & 1 deletion cypress/integration/sampleBlog.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,16 @@ context('check first integration test', () => {
.should('have', 'posts');
});

it('check link to have target_blank in blog page 2', () => {
cy.visit('/blog/___UNPUBLISHED___k5nhcflm_SJwD4Z0QDrIHg1PGHo2mrfLZE8sfUsPy/');

cy.get('a[target]').should('have.attr', 'target', '_blank');
});

it('Check that the slow user mock template appears then disappears', () => {
cy.visit('/slow').reload();

cy.get('app-slow>h1').contains('Scully Not Generated');
console.log('HERE');
cy.wait(4100)
.get('app-slow>h1')
.contains('Scully Generated');
Expand Down