Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): support for markdown options like {:target="_blank"} #422

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Mar 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

allow additional attributes to be added to target anchors. It uses the same syntax as jekyll and kramdownL

[someLink](http://somewhere.com){:target="_blank" class="lnk ext"}

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jorgeucano jorgeucano merged commit b401d27 into master Mar 24, 2020
@jorgeucano jorgeucano deleted the sander/customMarkdownOptionsPlugin branch March 24, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants