video: Prefer loading system OpenH264 library to downloading it #17799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
openh264-system
branch
2 times, most recently
from
a9e6fbb
to
869e87c
Compare
|
Just a random observation on my Fedora 40 system: Meanwhile: http://ciscobinary.openh264.org/libopenh264-2.4.1-linux64.7.so.signed.md5.txt -> I don't know where this file is coming from, or why it's different... :/ |
|
Oh... https://fedoraproject.org/wiki/OpenH264
|
|
Never mind, it mattersn't, as discussed on Discord... 🙃 |
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
torokati44
reviewed
Sep 12, 2024
kjarosh
force-pushed
the
openh264-system
branch
2 times, most recently
from
281b295
to
ac209f9
Compare
torokati44
force-pushed
the
openh264-system
branch
from
ac209f9
to
3a892e6
Compare
torokati44
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM, thank you very much! 🥳
Now, to rebase #16794 again, on top of this... 😩
This value does not have to be a path, it can be a filename of a library that is automatically located on the system.
This struct represents the OpenH264 codec and makes it possible to reuse the reference to the OpenH264 library across decoders. It also adds better error handling.
By using the H264Codec struct, we can load OpenH264 early and reuse its instance for all decoders.
This struct makes it easier to manage os/arch-specific OpenH264 information.
Some systems do have OpenH264 installed and in order to get rid of the delay caused by downloading the library (and needlessly downloading it in the first place), an attempt is made first to load OpenH264 as a system library. When loading fails (or version is mismatched), only then Ruffle downloads OpenH264 and uses that version of the library.
kjarosh
force-pushed
the
openh264-system
branch
from
3a892e6
to
6caadb6
Compare
|
Just replaced one more occurrence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems do have OpenH264 installed and in order to get rid of the delay caused by downloading the library (and needlessly downloading it in the first place), an attempt is made first to load OpenH264 as a system library. When loading fails (or version is mismatched), only then Ruffle downloads OpenH264 and uses that version of the library.
This also will make it possible to support OpenH264 in Flatpak.