video: Use cache dir for storing downloaded OpenH264 library #17803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
openh264-dir
branch
from
c3c0c1f
to
4e21a70
Compare
Using the executable's parent directory is a bad idea in most cases, as the place where Ruffle is installed should not be modified. This patch changes the directory where the OpenH264 library is saved to the cache directory, which should always be writable.
kjarosh
force-pushed
the
openh264-dir
branch
from
4e21a70
to
7aef473
Compare
torokati44
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the executable's parent directory is a bad idea in most cases, as the place where Ruffle is installed should not be modified (often it's not even writable). This PR changes the directory where the OpenH264 library is saved to the cache directory, which should always be writable.