Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for Yaskawa Motoman GP180-120 6DOF arm #46

Closed
wants to merge 2 commits into from

Conversation

jmarsik
Copy link

@jmarsik jmarsik commented Jun 2, 2019

Meshes are derived from official Yaskawa 3D model files.

I didn't know if I should commit this to motoman_experimental or motoman repository ... is this the right one?

@gavanderhoorn
Copy link
Member

Thanks for the PR.

I didn't know if I should commit this to motoman_experimental or motoman repository ... is this the right one?

You may submit to ros-industrial/motoman directly. If @EricMarcil and/or @ted-miller review the submission I'm confident it is OK.

Unfortunately I cannot transfer PRs, so if/when you re-open there, I'll add some comments on specific aspects of the PR.

@EricMarcil
Copy link
Contributor

@gavanderhoorn: I will try to review it tomorrow and then if all is good we can put in the Motoman branch.

@gavanderhoorn
Copy link
Member

I'd prefer it if @jmarsik could submit to ros-industrial/motoman first and then ask you to do the review.

@jmarsik
Copy link
Author

jmarsik commented Jun 3, 2019

I will do that and post link to the new PR here. Probably tomorrow.

@jmarsik
Copy link
Author

jmarsik commented Jun 3, 2019

New pull request to motoman repository created, check it here ros-industrial/motoman#277

The Travis build is still failing here, just for ROS Indigo, there is something wrong with using properties in xacro file (property DEG2RAD). It works fine in ROS Kinetic.

@jmarsik jmarsik closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants