find Xcode preferentially without spotlight (v2) #4652
Conversation
|
Can't set status; build succeeded. |
| REALM_XCODE_VERSION="$version" sh build.sh ios-swift | ||
| REALM_XCODE_VERSION=$version | ||
| REALM_SWIFT_VERSION= | ||
| set_xcode_and_swift_versions |
There was a problem hiding this comment.
build.sh now calls set_xcode_and_swift_versions unconditionally, so it's superfluous to call it in all these package- commands. Also, REALM_SWIFT_VERSION= could be moved outside these for loops.
-for version in 8.0 8.1 8.2; do
-REALM_XCODE_VERSION=$version
-REALM_SWIFT_VERSION=
-set_xcode_and_swift_versions
+REALM_SWIFT_VERSION=
+for REALM_XCODE_VERSION in 8.0 8.1 8.2; doThere was a problem hiding this comment.
Both are actually needed, since set_xcode_and_swift_versions is the only one exporting it (so it can go to a child process), and it is also always setting REALM_SWIFT_VERSION so without that being inside the loop you would get it set to the value for the first one.
There was a problem hiding this comment.
You should still be able to do this, cutting down on some boilerplate:
-for version in 8.0 8.1 8.2; do
- REALM_XCODE_VERSION=$version
- REALM_SWIFT_VERSION=
- set_xcode_and_swift_versions
+REALM_SWIFT_VERSION=
+for REALM_XCODE_VERSION in 8.0 8.1 8.2; do
+ set_xcode_and_swift_versionsThere was a problem hiding this comment.
No, doing that would fail with a complaint that later versions of Xcode do not support the selected (one for Xcode 8.0) version of Swift.
|
This has been causing the @larkost could you please fix? Specifically it hangs at "waiting for simulator to boot...", never completing or moving on for hours. https://ci.realm.io/job/cocoa_docs/
|
No description provided.