Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Xcode selection for CI deterministic #4503

Closed
larkost opened this issue Jan 3, 2017 · 1 comment
Closed

make Xcode selection for CI deterministic #4503

larkost opened this issue Jan 3, 2017 · 1 comment
Assignees
@larkost
Labels
T-Test

Comments

@larkost
Copy link
Contributor

larkost commented Jan 3, 2017

In CI runs the script ./scripts/swift-version.sh to select the version of Xcode used for swift compiles. For most situations it is near-deterministic, but the listing order depends on Spotlights ordering (so a black box to us), as well as what the last version of Xcode selected on the system was.

We should make this completely deterministic, either by being explicit on the Swift->Xcode mappings, or by skipping the currently selected check and making the ordering completely deterministic. I lean to making this explicit, as it will better point out failures in the setup.
larkost added a commit that referenced this issue Jan 12, 2017
@larkost
fix for #4534, find xcode without spotlight
0ed82e4 
This avoids using spotlight to find Xcode if it can, avoiding some times when Spotlight has been unreliable on the CO machines. It also solves #4503 by making the selection of Xcode on CI machines deterministic (given identical installs of Xcode).
@larkost larkost mentioned this issue Jan 12, 2017
Merged
@larkost larkost mentioned this issue Feb 9, 2017
Merged
larkost added a commit that referenced this issue Feb 9, 2017
@larkost
find Xcode preferentially without spotlight - v2 (#4652)
942fd88 
fixes #4534 and #4503 by looking in `/Applications` for Xcode before using Spotlight, and skipping the current default Xcode when running under Jenkins.
@larkost larkost self-assigned this Feb 9, 2017
@larkost
Copy link
Contributor Author

larkost commented Feb 9, 2017

Fixed in 942fd88.

@larkost larkost closed this as completed Feb 9, 2017
@larkost larkost removed the S:Review label Feb 9, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larkost larkost

Labels
T-Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsim @larkost