Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attrs tests #15124

Merged
merged 2 commits into from
Apr 26, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
more rename
  • Loading branch information
ikonst committed Apr 25, 2023
commit 4305b0d4bd671d0f673bcfc0a4c8f01e1f7b9c6b
2 changes: 1 addition & 1 deletion test-data/unit/check-classes.test
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ main:7: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incom
[case testEqMethodsOverridingWithNonObjects]
class A:
def __eq__(self, other: A) -> bool: pass # Fail
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]
[out]
main:2: error: Argument 1 of "__eq__" is incompatible with supertype "object"; supertype defines the argument type as "object"
main:2: note: This violates the Liskov substitution principle
Expand Down
6 changes: 3 additions & 3 deletions test-data/unit/check-flags.test
Original file line number Diff line number Diff line change
Expand Up @@ -1311,7 +1311,7 @@ import attr
class Unannotated:
foo = attr.ib()

[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]

[case testDisallowIncompleteDefsAttrsWithAnnotations]
# flags: --disallow-incomplete-defs
Expand All @@ -1321,7 +1321,7 @@ import attr
class Annotated:
bar: int = attr.ib()

[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]

[case testDisallowIncompleteDefsAttrsPartialAnnotations]
# flags: --disallow-incomplete-defs
Expand All @@ -1332,7 +1332,7 @@ class PartiallyAnnotated: # E: Function is missing a type annotation for one or
bar: int = attr.ib()
baz = attr.ib()

[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]

[case testAlwaysTrueAlwaysFalseFlags]
# flags: --always-true=YOLO --always-true=YOLO1 --always-false=BLAH1 --always-false BLAH --ignore-missing-imports
Expand Down
4 changes: 2 additions & 2 deletions test-data/unit/check-incremental.test
Original file line number Diff line number Diff line change
Expand Up @@ -3069,7 +3069,7 @@ from attr import attrib, attrs
class A:
a: int

[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]
[rechecked]
[stale]
[out2]
Expand Down Expand Up @@ -3410,7 +3410,7 @@ class C:
b: int = attr.ib(converter=int)
c: A = attr.ib(converter=A)
d: int = attr.ib(converter=parse)
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]
[out1]
main:6: note: Revealed type is "def (a: Union[builtins.float, builtins.str], b: Union[builtins.str, builtins.bytes, builtins.int], c: builtins.str, d: Union[builtins.int, builtins.str]) -> a.C"
main:10: note: Revealed type is "def (a: Union[builtins.float, builtins.str], b: Union[builtins.str, builtins.bytes, builtins.int], c: builtins.str, d: Union[builtins.int, builtins.str], x: builtins.str) -> __main__.D"
Expand Down
6 changes: 3 additions & 3 deletions test-data/unit/fine-grained-attr.test
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ from attr import define
@define
class A:
a: float
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]
[out]
==
main:5: error: Incompatible return value type (got "Attribute[float]", expected "Attribute[int]")
Expand All @@ -32,7 +32,7 @@ from attr import define
class A:
a: float
b: int
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]

[file m.py]
from c import A
Expand All @@ -54,7 +54,7 @@ import attr
@attr.s
class Entry:
var: int = attr.ib()
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]

[file m.py]
from typing import Any, ClassVar, Protocol
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/fine-grained.test
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ import attr
@attr.s(kw_only=True)
class A:
a = attr.ib(15) # type: int
[builtins fixtures/attr.pyi]
[builtins fixtures/plugin_attrs.pyi]
[out]
==
main:2: error: Too many positional arguments for "B"
Expand Down