Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename attrs tests #15124

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Rename attrs tests #15124

merged 2 commits into from
Apr 26, 2023

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented Apr 25, 2023 •
edited
Loading

  • the library is named "attrs", not "attr"1
  • "attrs" could mean a test of Python attributes, so adding "plugin"

Footnotes

  1. at some point we'd also need to change tests to use attrs.define and attrs.fields in all but tests meant to exercise the "old API" ↩

hauntsaninja
hauntsaninja approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hauntsaninja hauntsaninja merged commit 16b936c into python:master Apr 26, 2023
@ikonst ikonst deleted the 2023-04-25-rename-attrs branch April 26, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikonst @hauntsaninja