bpo-42874: Remove grep -qE options for Solaris 10 compatibility #24200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to bpo-42874, some versions of grep do not support the -q and -E options. Although both options are used elsewhere in the configure script, this particular bit of validation can be achieved without them, so there's no real harm in using a grep call with no flags. bpo-42874: https://bugs.python.org/issue42874
pganssle
force-pushed
the
vanilla_grep
branch
from
03fa9f2
to
32e1d4f
Compare
pablogsal
approved these changes
Jan 12, 2021
|
Wow, I added auto-merge but I intend to add |
|
Well, let's see if the build bots complain, if that's the case I will manually revert it. Apologies for that :( |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…onGH-24200) According to [bpo-42874](), some versions of grep do not support the `-q` and `-E` options. Although both options are used elsewhere in the configure script, this particular bit of validation can be achieved without them, so there's no real harm in using a grep call with no flags. Would be good to get some people taking advantage of the `--with-tzpath` arguments in the wild to try this out.. Local testing seems to indicate that this does the same thing, but I don't know that we have any buildbots using this option. Maybe @pablogsal? [bpo-42874]():
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to bpo-42874, some versions of grep do not support the
-qand-Eoptions. Although both options are used elsewhere in the configure script, this particular bit of validation can be achieved without them,so there's no real harm in using a grep call with no flags.
Would be good to get some people taking advantage of the
--with-tzpatharguments in the wild to try this out.. Local testing seems to indicate that this does the same thing, but I don't know that we have any buildbots using this option. Maybe @pablogsal?bpo-42874: https://bugs.python.org/issue42874
https://bugs.python.org/issue42874
Automerge-Triggered-By: GH:pablogsal