bpo-37218: Change digestmod deprecation notice to versionchanged #13947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code change was made in python#7063, for https://bugs.python.org/issue33604.
In case readers of the documentation are taking this exmaple as some form of recommendation, change it to a hashing alogrithm without known collision attacks. As https://tools.ietf.org/html/rfc6151 notes "attacks on HMAC-MD5 do not seem to indicate a practical vulnerability when used as a message authentication code", but "for a new protocol design, a ciphersuite with HMAC-MD5 should not be included". On this basis I think it's best not to mention it here.
mangrisano
approved these changes
Jun 12, 2019
|
The wording for this was changed in #16805. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37218